Refactor AttributeAddQuery to support node with an attribute of the same name previously active #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
ajtmccarty
approved these changes
Oct 25, 2024
| MATCH path1 = (root:Root)<-[r1:IS_PART_OF]-(n) | ||
| OPTIONAL MATCH path2 = (n)-[r2:HAS_ATTRIBUTE]-(:Attribute { name: $attr_name }) | ||
| WHERE all(r IN relationships(path1) WHERE (%(branch_filter)s)) | ||
| AND all(r IN relationships(path2) WHERE (%(branch_filter)s)) |
There was a problem hiding this comment.
WHERE all(r in [r1, r2] WHERE (%(branch_filter)s))
| WITH n1 as n, r1 as rb | ||
| WHERE rb.status = "active" | ||
| WITH n1 as n, r11 as r1, r12 as r2 | ||
| WHERE (r1.status = "active" and r2 is null) OR (r1.status = "active" and r2.status = "deleted") |
There was a problem hiding this comment.
WHERE r1.status = "active" AND (r2 IS NULL OR r2.status = "deleted")
| ) | ||
| assert len(persons) == 1 | ||
| john = persons[0] | ||
| john.height.value = 200 |
There was a problem hiding this comment.
maybe add an assert that the value is None before updating it to check that John's initial height was deleted
| assert query.get_nbr_migrations_executed() == 2 | ||
|
|
||
| # ------------------------------------------ | ||
| # Delete the attribute Color |
There was a problem hiding this comment.
Add the attribute color
dgarros
force-pushed
the
dga-20241025-fix-4727
branch
from
005f7d0
to
d42f7eb
Compare
…ame name previously active
dgarros
force-pushed
the
dga-20241025-fix-4727
branch
from
d42f7eb
to
50d5806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4727