Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload menu when switching branch #4776

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/app/src/components/account-menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const UnauthenticatedAccountMenu = () => {
return (
<DropdownMenu>
<Link
className="flex items-center h-14 w-full rounded-lg p-2 gap-2 hover:bg-indigo-50 overflow-hidden"
className="flex items-center h-14 w-full rounded-lg p-2 gap-2 hover:bg-indigo-50 overflow-hidden shrink-0"
to="/login"
state={{ from: location }}
>
Expand Down Expand Up @@ -206,7 +206,7 @@ const AuthenticatedAccountMenu = ({

const AccountMenuSkeleton = () => {
return (
<div className="flex items-center gap-2 p-2">
<div className="flex items-center gap-2 p-2 shrink-0">
<Skeleton className="rounded-full h-10 w-10" />

<div className="flex-grow space-y-2 group-data-[collapsed=true]/sidebar:hidden">
Expand Down
14 changes: 13 additions & 1 deletion frontend/app/src/hooks/useAuth.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { components } from "@/infraops";
import { configState } from "@/state/atoms/config.atom";
import { parseJwt } from "@/utils/common";
import { fetchUrl } from "@/utils/fetch";
import { ObservableQuery } from "@apollo/client";
import { useAtom } from "jotai/index";
import { ReactElement, ReactNode, createContext, useContext, useState } from "react";
import { Navigate, useLocation } from "react-router-dom";
Expand Down Expand Up @@ -47,6 +48,12 @@ export const removeTokensInLocalStorage = () => {
localStorage.removeItem(REFRESH_TOKEN_KEY);
};

const QUERY_TO_IGNORE = ["GET_PROFILE_DETAILS"];

const shouldIgnoreQuery = (observableQuery: ObservableQuery) => {
return !!observableQuery.queryName && QUERY_TO_IGNORE.includes(observableQuery.queryName);
};

export const getNewToken = async () => {
const refreshToken = localStorage.getItem(REFRESH_TOKEN_KEY);

Expand Down Expand Up @@ -126,7 +133,12 @@ export function AuthProvider({ children }: { children: ReactNode }) {
const signOut = () => {
removeTokensInLocalStorage();
setAccessToken(null);
graphqlClient.refetchQueries({ include: "active" });
graphqlClient.refetchQueries({
include: "active",
onQueryUpdated(observableQuery) {
return !shouldIgnoreQuery(observableQuery);
},
});
};

const data = parseJwt(accessToken);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useAuth } from "@/hooks/useAuth";
import { MenuSectionInternal } from "@/screens/layout/menu-navigation/components/menu-section-internal";
import { MenuSectionObject } from "@/screens/layout/menu-navigation/components/menu-section-object";
import { currentBranchAtom } from "@/state/atoms/branches.atom";
import { currentSchemaHashAtom, menuAtom } from "@/state/atoms/schema.atom";
import { menuAtom } from "@/state/atoms/schema.atom";
import { fetchUrl } from "@/utils/fetch";
import { useAtom, useAtomValue } from "jotai";
import { useEffect, useState } from "react";
Expand All @@ -19,12 +19,11 @@ export interface MenuNavigationProps {
export default function MenuNavigation({ isCollapsed }: MenuNavigationProps) {
const { accessToken } = useAuth();
const currentBranch = useAtomValue(currentBranchAtom);
const currentSchemaHash = useAtomValue(currentSchemaHashAtom);
const [menu, setMenu] = useAtom(menuAtom);
const [isLoading, setIsLoading] = useState(false);

useEffect(() => {
if (!currentSchemaHash) return;
if (!currentBranch) return;

const headers = accessToken && {
authorization: `Bearer ${accessToken}`,
Expand All @@ -39,7 +38,7 @@ export default function MenuNavigation({ isCollapsed }: MenuNavigationProps) {
} finally {
setIsLoading(false);
}
}, [currentSchemaHash, accessToken]);
}, [currentBranch, accessToken]);

if (isLoading) return <div>Loading...</div>;
if (!menu?.sections) return <div className="flex-grow" />;
Expand Down
Loading