Convert BranchDelete task and event to Prefect #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
group/backend
CodSpeed Performance ReportMerging #4778 will degrade performances by 17.92%Comparing Summary
Benchmarks breakdown
|
github-actions
bot
added
the
type/documentation
dgarros
force-pushed
the
dga-20241030-events
branch
from
963b3cd
to
fd9194d
Compare
dgarros
force-pushed
the
dga-20241030-events
branch
from
fd9194d
to
2a178a9
Compare
ajtmccarty
reviewed
Oct 30, 2024
| @@ -27,7 +27,7 @@ def get_name(self) -> str: | |||
| def get_resource(self) -> dict[str, str]: | |||
| raise NotImplementedError | |||
|
|
|||
| def get_message(self) -> InfrahubMessage: | |||
| def get_messages(self) -> list[InfrahubMessage]: | |||
| raise NotImplementedError | |||
| proposed_change: CoreProposedChange = await NodeManager.get_one_by_id_or_default_filter( | ||
| db=db, id=prepare_proposed_change, kind=InfrahubKind.PROPOSEDCHANGE | ||
| ) | ||
| assert proposed_change.state.value.value == ProposedChangeState.CANCELED.value |
There was a problem hiding this comment.
should there be new unit tests to cover the deleted ones in this module and those below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the following tasks/messages to Prefect :
RequestProposedChangeCancelTriggerProposedChangeCancelEventBranchDelete