-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert BranchDelete task and event to Prefect #4778
base: develop-1.1
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #4778 will degrade performances by 17.92%Comparing Summary
Benchmarks breakdown
|
963b3cd
to
fd9194d
Compare
fd9194d
to
2a178a9
Compare
@@ -27,7 +27,7 @@ def get_name(self) -> str: | |||
def get_resource(self) -> dict[str, str]: | |||
raise NotImplementedError | |||
|
|||
def get_message(self) -> InfrahubMessage: | |||
def get_messages(self) -> list[InfrahubMessage]: | |||
raise NotImplementedError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotImplentedError()
proposed_change: CoreProposedChange = await NodeManager.get_one_by_id_or_default_filter( | ||
db=db, id=prepare_proposed_change, kind=InfrahubKind.PROPOSEDCHANGE | ||
) | ||
assert proposed_change.state.value.value == ProposedChangeState.CANCELED.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be new unit tests to cover the deleted ones in this module and those below?
This PR converts the following tasks/messages to Prefect :
RequestProposedChangeCancel
TriggerProposedChangeCancel
EventBranchDelete