Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize transform using __init__() #4782

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ogenstad
Copy link
Contributor

This change is in preparation of opsmill/infrahub-sdk-python#81.

Instead of creating a transform instance with:

transform = await Transform.init()

We use:

transform = Transform()

One of the goals here is to avoid having InfrahubClient as an import outside of TYPE_CHECKING within the main transforms file.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 30, 2024
@ogenstad ogenstad changed the title Initialize transform using __init__() Initialize transform using __init__() (can go into 1.0.1 if it's too late for 1.0.0) Oct 30, 2024
@ogenstad ogenstad marked this pull request as ready for review October 30, 2024 13:16
@ogenstad ogenstad requested a review from a team October 30, 2024 13:16
@ogenstad ogenstad changed the title Initialize transform using __init__() (can go into 1.0.1 if it's too late for 1.0.0) Initialize transform using __init__() Oct 30, 2024
@ogenstad ogenstad merged commit 9f7300a into release-1.0 Oct 30, 2024
28 checks passed
@ogenstad ogenstad deleted the pog-avoid-using-transform.init branch October 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants