Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PTH103 os.makedirs() should be replaced by Path.mkdir #4791

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix PTH103 os.makedirs() should be replaced by Path.mkdir #4791

merged 1 commit into from
Oct 31, 2024

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Oct 30, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 30, 2024
@ogenstad ogenstad changed the title Fix PTH103 os.makedirs() should be replaced by `Path.mkdir(parents=… Fix PTH103 os.makedirs() should be replaced by Path.mkdir Oct 30, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #4791 will degrade performances by 17.98%

Comparing pog-pth103 (987c463) with develop (fad721d)

Summary

❌ 2 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop pog-pth103 Change
❌ test_get_menu 421.5 ms 473.9 ms -11.07%
❌ test_graphql_generate_schema 300.4 ms 366.3 ms -17.98%

@ogenstad ogenstad marked this pull request as ready for review October 31, 2024 06:13
@ogenstad ogenstad merged commit 57baceb into develop-1.1 Oct 31, 2024
27 of 28 checks passed
@ogenstad ogenstad deleted the pog-pth103 branch October 31, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarros dgarros dgarros approved these changes

Assignees
No one assigned
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogenstad @dgarros