Avoid useless call to schema load api on repo import #4796
Merged
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed locally that I had a repo import fail because the schema load API timed out after two minutes, however I didn't have any schemas within my repo so the API should never have been called.
There's also a problem on the actual API in the sense that it can waste time and resources if a user calls it with an empty array. If this is done we can either report it as a user error alternatively we send back a
SchemaUpdate
indicating that the hash remained the same and that there were no updates. Thoughts around this?Targeting
stable
so it's included in 1.0.1.