allow to customize postgres service and image source #4812
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DisasteR
force-pushed
the
update-compose-file
branch
from
dd44e86
to
a0adbee
Compare
dgarros
reviewed
Oct 31, 2024
There was a problem hiding this comment.
The changes looks good to me but I think the changes need to be integrated into the stable branch, not develop to show up in https://infrahub.opsmill.io/
Do you mind cherry picking your commit into a new branch based on stable
thanks
BeArchiTek
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Thank you for your PR @DisasteR !
LGTM. I do have a small remark on my side, I don't think we should add those in x-infrahub-config but create another anchor dedicated to task-manager configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow deployment of infrahub when using a docker registry proxy.
and customization of postgres auth
Will affect ansible install role when propagated to https://infrahub.opsmill.io/