Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add merge rollback logic #4818

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Oct 31, 2024

fixes #4448
IFC-732

moves the call to merge a branch out of a transaction b/c a large merge was too big of a transaction and caused an OOM error
instead of a transaction, the merge is inside of a try-except block that will use a new query to roll the merge back

  • also fixes a bug in the merge query that prevented IS_RELATED edges from getting set to status="deleted" in some scenarios where the was a conflict
  • and removes the conflict_resolution argument to the merge, b/c conflict information is stored in the diff now

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 31, 2024
Copy link

codspeed-hq bot commented Oct 31, 2024

CodSpeed Performance Report

Merging #4818 will degrade performances by 18.72%

Comparing ajtm-10312024-merge-rollback (a62d0f2) with stable (b2928f9)

Summary

❌ 1 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark stable ajtm-10312024-merge-rollback Change
test_schemabranch_duplicate 309.7 µs 381 µs -18.72%

@ajtmccarty ajtmccarty marked this pull request as ready for review October 31, 2024 22:15
@ajtmccarty ajtmccarty requested a review from a team October 31, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unable to merge branch with large data change
1 participant