Call OS functions in User-Agent Creation #230
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a user-agent, the SDK uses
os.platform
andos.release
as strings, though technically, they are both functions. This typically is not an issue, since template strings will simply convert these to the proper value, which is intended behavior.For instance:
However, when using Bun, this causes an issue, and causes an error. Though the SDK by no means supports Bun officially yet, this simple fix helps support it.