Refactor code reported by Sonarqube #415
trungbachAnnotations
8 errors and 2 warnings
|
packages/universal-swap/tests/helper.spec.ts > test helper functions > test-getRoute-given usd-coin coingecko id, chain id 0x01, send-to tether, chain id 0x2b6653dc with receiver 0x1234 should have swapRoute { swapRoute: 'ChV0cm9udHJ4LW1haW5uZXQweDEyMzQSCmNoYW5uZWwtMjkaOXRyb250cngtbWFpbm5ldDB4YTYxNGY4MDNCNkZENzgwOTg2QTQyYzc4RWM5YzdmNzdlNkRlRDEzQw==', universalSwapType: 'other-networks-to-oraichain' }:
packages/universal-swap/tests/helper.spec.ts#L401
AssertionError: expected false to deeply equal true
- Expected
+ Received
- true
+ false
❯ packages/universal-swap/tests/helper.spec.ts:401:27
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test-combineSwapMsgOraichain-with-from-and-to-is-have-dont-have-same-coingecko-id:
packages/universal-swap/tests/index.spec.ts#L453
AssertionError: expected [ { …(2) }, { …(2) } ] to deeply equal [ { …(2) }, { …(2) } ]
- Expected
+ Received
Array [
Object {
"typeUrl": "/cosmwasm.wasm.v1.MsgExecuteContract",
"value": Object {
"contract": "orai12hzjxfh77wl572gdzct2fxv2arxcwh6gykc7qh",
"funds": Array [],
- "msg": "{\"send\":{\"contract\":\"orai1j0r67r9k8t34pnhy00x3ftuxuwg0r6r4p8p6rrc8az0ednzr8y9s3sj2sf\",\"amount\":\"100000\",\"msg\":\"eyJleGVjdXRlX3N3YXBfb3BlcmF0aW9ucyI6eyJvcGVyYXRpb25zIjpbeyJvcmFpX3N3YXAiOnsib2ZmZXJfYXNzZXRfaW5mbyI6eyJ0b2tlbiI6eyJjb250cmFjdF9hZGRyIjoib3JhaTEyaHpqeGZoNzd3bDU3MmdkemN0MmZ4djJhcnhjd2g2Z3lrYzdxaCJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fX19LHsib3JhaV9zd2FwIjp7Im9mZmVyX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoiaWJjLzlDNERDRDIxQjQ4MjMxRDBCQzJBQzNEMUI3NEE4NjQ3NDZCMzdFNDI5MjY5NEM5M0M2MTczMjQyNTBEMDAyRkMifX19fV0sIm1pbmltdW1fcmVjZWl2ZSI6IjEwMDAwIn19\"}}",
+ "msg": "{\"send\":{\"contract\":\"orai1j0r67r9k8t34pnhy00x3ftuxuwg0r6r4p8p6rrc8az0ednzr8y9s3sj2sf\",\"amount\":\"100000\",\"msg\":\"eyJleGVjdXRlX3N3YXBfb3BlcmF0aW9ucyI6eyJvcGVyYXRpb25zIjpbeyJvcmFpX3N3YXAiOnsib2ZmZXJfYXNzZXRfaW5mbyI6eyJ0b2tlbiI6eyJjb250cmFjdF9hZGRyIjoib3JhaTEyaHpqeGZoNzd3bDU3MmdkemN0MmZ4djJhcnhjd2g2Z3lrYzdxaCJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fX19LHsib3JhaV9zd2FwIjp7Im9mZmVyX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoiaWJjLzlDNERDRDIxQjQ4MjMxRDBCQzJBQzNEMUI3NEE4NjQ3NDZCMzdFNDI5MjY5NEM5M0M2MTczMjQyNTBEMDAyRkMifX19fV0sIm1pbmltdW1fcmVjZWl2ZSI6IjAifX0=\"}}",
"sender": "orai1g4h64yjt0fvzv5v2j8tyfnpe5kmnetejvfgs7g",
},
},
Object {
"typeUrl": "/ibc.applications.transfer.v1.MsgTransfer",
"value": Object {
"memo": "",
"receiver": "orai1234",
"sender": "orai1g4h64yjt0fvzv5v2j8tyfnpe5kmnetejvfgs7g",
"sourceChannel": "channel-13",
"sourcePort": "transfer",
"timeoutHeight": undefined,
"timeoutTimestamp": Long {
"high": 0,
"low": 0,
"unsigned": false,
},
"token": Object {
"amount": "100",
"denom": "ibc/9C4DCD21B48231D0BC2AC3D1B74A864746B37E4292694C93C617324250D002FC",
},
},
},
]
❯ packages/universal-swap/tests/index.spec.ts:453:9
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test getTranferAddress should return transferAddress correctly & throw error correctly:
packages/universal-swap/tests/index.spec.ts#L552
AssertionError: expected undefined to deeply equal 'Please login metamask / tronlink!'
- Expected:
"Please login metamask / tronlink!"
+ Received:
undefined
❯ packages/universal-swap/tests/index.spec.ts:552:36
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test-generateMsgsSwap-for-swap-tokens-that-both-belong-to-Oraichain-from-is-native-token:
packages/universal-swap/tests/index.spec.ts#L783
AssertionError: expected { execute_swap_operations: { …(3) } } to deeply equal { execute_swap_operations: { …(2) } }
- Expected
+ Received
Object {
"execute_swap_operations": Object {
- "minimum_receive": "10000",
+ "minimum_receive": "0",
"operations": Array [
Object {
"orai_swap": Object {
"ask_asset_info": Object {
"token": Object {
"contract_addr": "orai10ldgzued6zjp0mkqwsv2mux3ml50l97c74x8sg",
},
},
"offer_asset_info": Object {
"native_token": Object {
"denom": "orai",
},
},
},
},
],
+ "to": undefined,
},
}
❯ packages/universal-swap/tests/index.spec.ts:783:30
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test-generateMsgsSwap-for-swap-tokens-that-both-belong-to-Oraichain-from-is-cw20-token:
packages/universal-swap/tests/index.spec.ts#L783
AssertionError: expected { send: { …(3) } } to deeply equal { send: { …(3) } }
- Expected
+ Received
Object {
"send": Object {
"amount": "100000",
"contract": "orai1j0r67r9k8t34pnhy00x3ftuxuwg0r6r4p8p6rrc8az0ednzr8y9s3sj2sf",
- "msg": "eyJleGVjdXRlX3N3YXBfb3BlcmF0aW9ucyI6eyJvcGVyYXRpb25zIjpbeyJvcmFpX3N3YXAiOnsib2ZmZXJfYXNzZXRfaW5mbyI6eyJ0b2tlbiI6eyJjb250cmFjdF9hZGRyIjoib3JhaTEyaHpqeGZoNzd3bDU3MmdkemN0MmZ4djJhcnhjd2g2Z3lrYzdxaCJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fX19LHsib3JhaV9zd2FwIjp7Im9mZmVyX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsidG9rZW4iOnsiY29udHJhY3RfYWRkciI6Im9yYWkxMGxkZ3p1ZWQ2empwMG1rcXdzdjJtdXgzbWw1MGw5N2M3NHg4c2cifX19fV0sIm1pbmltdW1fcmVjZWl2ZSI6IjEwMDAwIn19",
+ "msg": "eyJleGVjdXRlX3N3YXBfb3BlcmF0aW9ucyI6eyJvcGVyYXRpb25zIjpbeyJvcmFpX3N3YXAiOnsib2ZmZXJfYXNzZXRfaW5mbyI6eyJ0b2tlbiI6eyJjb250cmFjdF9hZGRyIjoib3JhaTEyaHpqeGZoNzd3bDU3MmdkemN0MmZ4djJhcnhjd2g2Z3lrYzdxaCJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fX19LHsib3JhaV9zd2FwIjp7Im9mZmVyX2Fzc2V0X2luZm8iOnsibmF0aXZlX3Rva2VuIjp7ImRlbm9tIjoib3JhaSJ9fSwiYXNrX2Fzc2V0X2luZm8iOnsidG9rZW4iOnsiY29udHJhY3RfYWRkciI6Im9yYWkxMGxkZ3p1ZWQ2empwMG1rcXdzdjJtdXgzbWw1MGw5N2M3NHg4c2cifX19fV0sIm1pbmltdW1fcmVjZWl2ZSI6IjAifX0=",
},
}
❯ packages/universal-swap/tests/index.spec.ts:783:30
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test-combineMsgEvm-with-from-and-to-dont-have-same-coingecko-id-should-return-msg-swap-combined-with-msg-transfer-to-remote:
packages/universal-swap/tests/index.spec.ts#L977
AssertionError: expected [ { …(2) }, { …(2) } ] to deeply equal [ { …(2) }, { …(2) } ]
- Expected
+ Received
Array [
Object {
"typeUrl": "/cosmwasm.wasm.v1.MsgExecuteContract",
"value": Object {
"contract": "orai1j0r67r9k8t34pnhy00x3ftuxuwg0r6r4p8p6rrc8az0ednzr8y9s3sj2sf",
"funds": Array [
Object {
"amount": "100000",
"denom": "orai",
},
],
"msg": Uint8Array [
123,
34,
101,
120,
101,
99,
117,
116,
101,
95,
115,
119,
97,
112,
95,
111,
112,
101,
114,
97,
116,
105,
111,
110,
115,
34,
58,
123,
34,
111,
112,
101,
114,
97,
116,
105,
111,
110,
115,
34,
58,
91,
123,
34,
111,
114,
97,
105,
95,
115,
119,
97,
112,
34,
58,
123,
34,
111,
102,
102,
101,
114,
95,
97,
115,
115,
101,
116,
95,
105,
110,
102,
111,
34,
58,
123,
34,
110,
97,
116,
105,
118,
101,
95,
116,
111,
107,
101,
110,
34,
58,
123,
34,
100,
101,
110,
111,
109,
34,
58,
34,
111,
114,
97,
105,
34,
125,
125,
44,
34,
97,
115,
107,
95,
97,
115,
115,
101,
116,
95,
105,
110,
102,
111,
34,
58,
123,
34,
116,
111,
107,
101,
110,
34,
58,
123,
34,
99,
111,
110,
116,
114,
97,
99,
116,
95,
97,
100,
100,
114,
34,
58,
34,
111,
114,
97,
105,
49,
48,
108,
100,
103,
122,
117,
101,
100,
54,
122,
106,
112,
48,
109,
107,
113,
119,
115,
118,
50,
109,
117,
120,
51,
109,
108,
53,
48,
108,
57,
55,
99,
55,
52,
120,
56,
115,
103,
34,
125,
125,
125,
125,
93,
44,
34,
109,
105,
110,
105,
109,
117,
109,
95,
114,
101,
99,
101,
105,
118,
101,
34,
58,
34,
- 49,
- 48,
- 48,
- 48,
48,
34,
125,
125,
],
"sender": "orai1g4h64yjt0fvzv5v2j8tyfnpe5kmnetejvfgs7g",
},
},
Object {
"typeUrl": "/cosmwasm.wasm.v1.MsgExecuteContract",
"value": Object {
"contract": "orai10ldgzued6zjp0mkqwsv2mux3ml50l97c74x8sg",
"funds": Arr
|
|
packages/universal-swap/tests/index.spec.ts > test universal swap handler functions > test-combineMsgEvm-should-throw-error:
packages/universal-swap/tests/index.spec.ts#L989
AssertionError: expected undefined to deeply equal 'Please login cosmos wallet!'
- Expected:
"Please login cosmos wallet!"
+ Received:
undefined
❯ packages/universal-swap/tests/index.spec.ts:989:34
|
|
test (18.18.0, ubuntu-latest)
Process completed with exit code 1.
|
|
test (18.18.0, ubuntu-latest)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: styfle/[email protected], actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
test (18.18.0, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|