Merge pull request #30 from ebocher/release_fix

New fix. I hope
orbisgis · Sep 25, 2024 · 72aa662 · 72aa662
2 parents 6a67f08 + 1d9d995
commit 72aa662
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 25 deletions.
diff --git a/pom.xml b/pom.xml
@@ -289,15 +289,6 @@
                         <doclint>all,-missing</doclint>
                         <quiet>true</quiet>
                     </configuration>
-                    <executions>
-                        <execution>
-                            <id>attach-javadocs</id>
-                            <phase>verify</phase>
-                            <goals>
-                                <goal>jar</goal>
-                            </goals>
-                        </execution>
-                    </executions>
                 </plugin>
                 <!-- Maven release generation -->
                 <plugin>

diff --git a/src/main/java/module-info.java b/src/main/java/module-info.java
diff --git a/src/main/java/org/orbisgis/demat/JavascriptEngine.java b/src/main/java/org/orbisgis/demat/JavascriptEngine.java
@@ -123,9 +123,8 @@ void initV8Engine() throws JavetException, IOException {
     /**
      * Save the vega-lite chart in a SVG file
      *
-     * @param outputFile
-     * @return
-     * @throws JavetException
+     * @param outputFile the file to store the result
+     * @return the absolute path of the file
      */
     public String saveSVG(String json, File outputFile, boolean delete) throws JavetException, IOException {
         if (outputFile.exists()) {
@@ -167,8 +166,9 @@ public String saveSVG(String json, File outputFile, boolean delete) throws Javet
      * Save the vega-lite chart in a PNG file
      *
      * @param outputFile
-     * @return
-     * @throws JavetException
+     * @param vega_spec the input vega spec
+     * @param outputFile the file to store the result
+     * @return the absolute path of the file
      */
     public String savePNG(String vega_spec, File outputFile, boolean delete, float ratio) throws JavetException {
         if (outputFile.exists()) {