Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for cross-environment compatibility #23

Merged
merged 1 commit into from
May 9, 2024

Conversation

SnirShechter
Copy link
Contributor

@SnirShechter SnirShechter commented May 8, 2024

The package uses Path(), but its output differs between Windows and Linux - slash vs backslash.

This fix makes sure path is always represented with slashes.

@orsinium

Copy link

netlify bot commented May 8, 2024

Deploy Preview for mypy-baseline ready!

Name Link
🔨 Latest commit 5212650
🔍 Latest deploy log https://app.netlify.com/sites/mypy-baseline/deploys/663bbe310315310008e921eb
😎 Deploy Preview https://deploy-preview-23--mypy-baseline.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@orsinium
Copy link
Member

orsinium commented May 9, 2024

Thank you! I assume you've tried mypy-baseline on a Windows machine. Does it work? Is this the only issue you faced?

@orsinium orsinium merged commit 2e65f49 into orsinium-labs:master May 9, 2024
6 checks passed
@SnirShechter
Copy link
Contributor Author

Thank you! I assume you've tried mypy-baseline on a Windows machine. Does it work? Is this the only issue you faced?

Yes! Works great 🙂

@SnirShechter SnirShechter deleted the patch-1 branch May 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants