feat: implement oidc settings api flow #3879
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR have the purpose to implement the possibility to allows users setup OIDC connections through API SettingsFlow.
Related issue(s)
#3311
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
However, all I have to do is delete the condition in [line 145 of the file selfservice/strategy/oidc/strategy_settings.go] (https://github.com/ory/kratos/blob/master/selfservice/strategy/oidc/strategy_settings.go#L145) to obtain the node link for my configured providers.
The button opens the Authorization Flow window (Google here), I've logged into my account and the window redirects to /self-service/methods/oidc/callback/google with query parameters code, state, scope...
But Kratos answers that I'm not authorized because there's no active session, since this call doesn't send the X-Session-Token header.
Now I don't know how to send my active session token obtained after the login/registration flow with the SessionTokenExchange in this OIDC method callback.
Any ideas @jonas-jonas, @vinckr ?