Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentry integration with logrus hooks #3882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marchetti554
Copy link

Hey! I'm adding a Sentry integration using hooks from logrus, it's quite simple to configure once you have created the project in Sentry 🙌
Please let me know what you think about this feature :)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jun 3, 2024

Hi there and thank you for your contributino!

Unfortunately we don't want to support vendor specific things such as Sentry as we Ory's architecture revolves around vendor-neutral standards such as OTEL or good ol' structured logging.

There is probably a way to pipe stderr to sentry though :) https://stackoverflow.com/questions/64573082/sending-log-output-to-sentry

@splaunov splaunov force-pushed the feat/sentry-integration branch from 0e0b6fb to 3e5442f Compare June 13, 2024 17:59
chore: fix libs

feat: make format ran

feat: sentry integration
@splaunov splaunov force-pushed the feat/sentry-integration branch from 3e5442f to 8bf3f7b Compare June 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants