Reduce stack trace in logs by handling empty response from service

oskariorg · Aug 15, 2023 · e4c2179 · e4c2179
1 parent 6600cf4
commit e4c2179
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java b/service-wfs-client/src/main/java/org/oskari/service/wfs/client/OskariWFSClient.java
@@ -84,6 +84,9 @@ protected static SimpleFeatureCollection getFeatures(String endPoint,
             url = IOHelper.constructUrl(endPoint, query);
             responseHeaders = OskariWFSClient.readResponseTo(endPoint, user, pass, query, baos);
             response = baos.toByteArray();
+            if (response.length == 0) {
+                throw new ServiceRuntimeException("Empty response from " + url);
+            }
             // TODO: Select parsing algorithm based on response headers (Content-Type)
             fc = parseGeoJSON(response, crs, url);
             if (fc != null) {
@@ -105,6 +108,9 @@ protected static SimpleFeatureCollection getFeatures(String endPoint,
         baos.reset();
         responseHeaders = OskariWFSClient.readResponseTo(endPoint, user, pass, query, baos);
         response = baos.toByteArray();
+        if (response.length == 0) {
+            throw new ServiceRuntimeException("Empty response from " + url);
+        }
         fc = parseGML(response, crs, url, user, pass, gmlDecoder);
         if (fc != null) {
             return fc;