Sotkanet improvements #1028
Merged
Sotkanet improvements #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into sotkanet-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only functional change is that when a Sotkanet indicator data doesn't have any values in the
value"column" we useabsValueinstead. If there are any values we always use them. This is a workaround since some indicators only have the absValue in the current API.This PR removes the extra caching that was used for Sotkanet. We don't really need to cache the responses from Sotkanet as we operate on the processed values that we already cache. Usage of cache keys in the statistical data functionalities has been harmonized to follow the same pattern and a new
CacheKeys.buildCacheKey()function was introduced to make this easier (service-statistics-common/src/main/java/fi/nls/oskari/control/statistics/util/CacheKeys.java). Some cache-keys changed slightly, but now it's possible to flush everything from single datasource since all keys are prefixed withoskari:stats:[data source id]: