Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stanford University and Healthcare Entities to Operator Tree #10038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shubham0523
Copy link

This PR introduces updates to the Name Suggestion Index (NSI) by adding Stanford University and related healthcare entities to the Operator Tree.

Changes Made:

  • Stanford University has been added to data/operators/amenity/university.json as an operator, complete with the necessary tags and location set.
  • Created entries for the following healthcare brands:
    • Stanford Health Care (Wikidata: Q130530819)
    • Stanford Medicine Partners (Wikidata: Q130530794)
    • Stanford Health Care Tri-Valley (Wikidata: Q130530767)

Summary:

These updates reflect the operational status of Stanford University and its healthcare affiliates, ensuring compliance with NSI guidelines. The newly created Wikidata pages facilitate proper integration and reference for these entities within the OpenStreetMap community.

@bhousel
Copy link
Member

bhousel commented Oct 14, 2024

I really dont understand whether or not this stuff belongs in NSI, but for sure those Wikidata pages you created do not have any details at all, and I would not be surprised if the Wikidata project admins delete them.

What's your motivation behind adding this stuff? You're getting pretty close to being banned.

@1ec5
Copy link
Member

1ec5 commented Oct 14, 2024

This is a followup to #10035 (comment). I asked @Shubham0523 to focus on the integrated healthcare systems that Stanford runs, which are actual brands, rather than the university itself.

The Wikidata items need further work: you put a lot of information in the description that should go in statements instead. The description itself can be much simpler. See:

https://github.com/osmlab/name-suggestion-index/wiki/Editing-Wikidata#adding-properties
https://wiki.openstreetmap.org/wiki/Key:brand:wikidata#Creating_a_Wikidata_item

@Snowysauce
Copy link
Collaborator

Following up on the above comments, the proposed change to operators/amenity/university matches only one OSM object. This change was rejected in #10035 for this reason, as have similar changes for other university campuses (#4779, #9181, #9917). NSI doesn't index standalone entities or entities with a very small number of OSM instances, and this specific portion of the PR needs to be discarded in order for the PR to potentially be accepted.

@Shubham0523
Copy link
Author

Thank you for the constructive feedback. As someone who is still learning the ropes in the open-source community, I genuinely apologise if my contributions have fallen short. My intention has always been to help, and I truly value the insights from experienced members like you. I will focus on enhancing the Wikidata items and ensure I include more detailed statements for the healthcare brands. I appreciate your guidance and am eager to improve with your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants