Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of location for charging station Eldrive #9891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neau
Copy link
Contributor

@neau neau commented Sep 2, 2024

No description provided.

@neau neau marked this pull request as ready for review September 2, 2024 11:54
@Dimitar5555
Copy link
Collaborator

Is Eldrive a Bulgarian company? If it is, does it directly operate the stations in Romania and Lithuania or it has subsidiaries there?

@kjonosm
Copy link
Collaborator

kjonosm commented Sep 2, 2024

Anyway, displayName should somehow correspond with the actual operator or brand name.

@Snowysauce Snowysauce added the locationSet Location related tagging label Sep 3, 2024
@Snowysauce Snowysauce added the needs discussion Waiting for other contributors to voice their opinion label Sep 27, 2024
@Snowysauce
Copy link
Collaborator

The proposed locationSet appears to be correct per https://eldrive.eu/#charging__station. The company has individual offices in each country according to the contact info at the bottom of the page, but I don't know if they're just offices or subsidiary headquarters. I've refrained from merging this because the brand uses English for branding in some capacity, and so it should have at minimum an operator:en tag (along with the relevant local language tag to specify what language the default name is in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
locationSet Location related tagging needs discussion Waiting for other contributors to voice their opinion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants