refactor: support multiple concurrent arb pairs & SQS API key #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
approved these changes
Jul 8, 2024
| @@ -0,0 +1 @@ | |||
| package osmosis | |||
There was a problem hiding this comment.
I'm assuming we will be using this in future PRs
| @@ -59,7 +61,27 @@ type Pool struct { | |||
|
|
|||
| func getOsmosisPriceAndRoute(tokenInDenom, tokenOutDenom string, tokenInAmount int64) (float64, []poolmanagertypes.SwapAmountInSplitRoute, error) { | |||
| url := fmt.Sprintf("%s?tokenIn=%d%s&tokenOutDenom=%s&humanDenoms=false", osmosisQuoteAPI, tokenInAmount, tokenInDenom, tokenOutDenom) | |||
| resp, err := http.Get(url) | |||
|
|
|||
| // Define the headers | |||
There was a problem hiding this comment.
Can we make it so that we try to get the SQS OSMOSIS API KEY from env, if doesnt exist just to a get without the sqs api key? (for those who does not have access to sqs api key but still wants to use the arb bot)
|
@p0mvn I'll take on this PR and get it merged 👍 |
Yes, please! Sorry, I haven't had the chance to come back to this yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.go)