Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solana assets from Picasso IBC #1608

Merged
merged 1 commit into from
May 29, 2024

Conversation

JafarAz
Copy link
Contributor

@JafarAz JafarAz commented May 28, 2024

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

  • Asset is registered to the Cosmos Chain Registry.
  • Add asset to bottom of zone_assets.json.
    • chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
    • path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
    • osmosis_verified is set to false
    • listing_date_time_utc is specified and accurate
    • Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).

@JafarAz
Copy link
Contributor Author

JafarAz commented May 28, 2024

added images in this PR

@JeremyParish69
Copy link
Contributor

Very good submission.
I only have two requests:
Please update the description/fill out the checklist as best you can.
Please update the names of the images being uploaded in the Chain Registry PR (to include to .pica part) (e.g, ;jitosol.png; -> ;jitosol.pica.png'). Currently the image names don't match the reference here.

@JeremyParish69 JeremyParish69 merged commit c326aed into osmosis-labs:main May 29, 2024
5 checks passed
@JeremyParish69
Copy link
Contributor

These assets can be viewed in preview mode: https://app.osmosis.zone/assets?show_preview_assets=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants