Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project improvements #197

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add project improvements #197

wants to merge 4 commits into from

Conversation

dmytro-strukov
Copy link

@davydovanton Hi! Thank you for the nice project for OSS owners and contributors. Can you please review?

@@ -72,6 +72,7 @@ group :test do
gem 'rspec'
gem 'rspec-hanami', github: 'davydovanton/rspec-hanami'
gem 'capybara'
gem 'capybara-screenshot'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we need this gem? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davydovanton It's simplify debugging for feature tests

@dmytro-strukov
Copy link
Author

@davydovanton Resolved conflicts, please merge if all is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants