-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present criteria as not-tables #113
base: main
Are you sure you want to change the base?
Conversation
Thanks for making this happen, I think this is the right approach. Something feels just a bit off with the list, but I can't put my finger on it. Perhaps it's the lack of a leading list mark on each line, or the use of an emdash 🤔 Just feels like it's almost there, but not quite. |
I considered putting them in an unordered list but I thought that would make it worse in terms of padding between entries. We could certainly solve that with CSS, but I don't think a list is quite the right approach. I do love emdashes, but we could potentially remove them here, or replace them with a colon. What about bolding the ID so that it stands out a little better?
|
This is much improved when I try to read this version compared to the table (especially on mobile) |
This is an improvement. I suggest we merge something soon, and then we can continue to refine it further as later PRs. Making it readable at all on small displays seems important to me. |
This improves small-screen readability and removes/moves extraneous information for easier skimming. Signed-off-by: Ben Cotton <[email protected]>
51bbccb
to
a7a47dc
Compare
It made me very sad to remove my emdashes, but I did. |
This improves small-screen readability and removes/moves extraneous information for easier skimming.
Some choices I made:
Preview available as https://funnelfiasco.github.io/security-baseline/
Fixes #99