Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline.yaml - NEW - OSPS-DO-14 #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SecurityCRob
Copy link
Contributor

suggested wording for OSPS-DO-14 for End-Of-Support statement

suggested wording for OSPS-DO-14

Signed-off-by: CRob <[email protected]>
@SecurityCRob SecurityCRob added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 18, 2024
Comment on lines +656 to +662
The project documentation MUST provide a
descriptive statement when releases or
versions are no longer supported and that
will no longer receive security updates.

This should be provided both in human and
machine-readable formats.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we mean "should" or "SHOULD" in the second sentence? If it's the "normal English 'should'", maybe we actually mean "MUST" instead? (Personally, I lean toward SHOULD, but I want to make sure I understand your intent)
  2. As a rule, I don't like the idea of multi-sentence criteria and definitely not multi-paragraph (in the <p> sense, not in the English sense). Could it be be re-written as "The project documentation MUST provide human- and machine-readable descriptive statements when releases are no longer supported and will not longer receive security updates"? (As a note, I condensed "releases or versions" to be "releases" because I'm not entirely clear that there's a meaningful distinction between the two). Or, if the intent was for having both human- and machine-readable be a strong suggestion but not a requirement, then we should move the second sentence into the implementation (which it sort of already is)

Comment on lines +667 to +670
Create a status check that checks the project's
version control system for support and/or lifecycle
statements. Publishing this in machine-readble
formats is preferable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "implementation" sections should tell projects how to implement it, not how to determine if it's true or not.

Maybe we need a new field, similar to the Best Practices badge's "autofill" field, to describe how a criterion could be automatically determined. Note that the Best Practices Badge has a "details" field that explains how projects can meet the criterion, and I believe that this is what the current "implementation" field is for.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for the implementation guidance to projects to be clear enough that someone defining automation can simply read the implementation description to determine how to check it. For example, "Publish support information in $FORMAT_X or $FORMAT_Y, with a link at $LOCATION to the support document."

Comment on lines +660 to +662

This should be provided both in human and
machine-readable formats.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This should be provided both in human and
machine-readable formats.

I like machine-processable formats, but I don't know of one for this use. I certainly don't know of any with widespread acceptance. Security-insights.yml can say when the project ends, but I don't think it can do more.

If there is one, please identify that (at least as an option) in the "implementation" section.

Comment on lines +669 to +670
statements. Publishing this in machine-readble
formats is preferable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any examples of machine-readable formats here? I 100% support using machine-readable formats, but it feels like the "implementation" section would be a good place to link to one or more examples if they exist.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reference OpenEoX and/or endoflife.date? I'm torn between preferring a halfway solution over complete uncertainty, and lacking much evidence that the format works.

Comment on lines +667 to +670
Create a status check that checks the project's
version control system for support and/or lifecycle
statements. Publishing this in machine-readble
formats is preferable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for the implementation guidance to projects to be clear enough that someone defining automation can simply read the implementation description to determine how to check it. For example, "Publish support information in $FORMAT_X or $FORMAT_Y, with a link at $LOCATION to the support document."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants