Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form #25

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

form #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
30e79e4
Delete package-lock.json
ivadimko Apr 25, 2019
deeb5ba
Update package.json
ivadimko Apr 25, 2019
19dfd74
Update .gitignore
ivadimko Apr 25, 2019
118a987
updated reference screenshot
ivadimko Apr 27, 2019
90a2d28
Updated url
ost-ptk May 17, 2019
89a0fd6
fix backstopConfig
ost-ptk May 17, 2019
f71c262
Add form value demo on submit to explain names for students (#127)
YuriiHoliuk Jul 23, 2019
7f8dfc2
remove tag name check (#128)
YuriiHoliuk Jul 24, 2019
8ba86e8
added backstopConfig module, change config file.
ost-ptk Jul 24, 2019
6168b74
Merge pull request #130 from mate-academy/backstopConfig
ost-ptk Jul 25, 2019
c80ab46
changed http-server to browsersync
ost-ptk Aug 29, 2019
6e91549
Merge pull request #166 from mate-academy/browsersync
ost-ptk Aug 29, 2019
d32fd5e
Simple development
mgrinko Oct 8, 2019
ee7e052
Merge pull request #203 from mate-academy/simple-dev
mgrinko Oct 8, 2019
95155ef
Deploy was fixed
mgrinko Oct 9, 2019
d33378a
Update package.json
YuriiHoliuk Dec 16, 2019
d76b304
line-breaking
irenhh Dec 18, 2019
317c69d
upgrade to @mate-academy/scripts (#374)
YuriiHoliuk May 24, 2020
ff59bcb
fix npm vulnerabilities(npm audit fix --force)
YuriiHoliuk May 24, 2020
6f83d6e
Merge pull request #375 from mate-academy/mate-scripts-update
YuriiHoliuk May 24, 2020
e29740c
remove unneeded browser-sync
YuriiHoliuk May 25, 2020
3c02a76
Merge pull request #376 from mate-academy/mate-scripts-update
YuriiHoliuk May 25, 2020
f38eddf
Create checklist.md
irenhh Jun 30, 2020
37b6bef
Update checklist.md
irenhh Jun 30, 2020
67619e9
Update checklist.md
vkryvytskyy Jul 6, 2020
b204878
Update checklist.md
irenhh Nov 6, 2020
85f3a10
Update readme.md
solaryasha Jan 14, 2021
a642784
Update readme.md
mgrinko Mar 16, 2021
71521f2
update @mate-academy/scripts to 0.8.0
Vladimir-Beliy Mar 16, 2021
466ff16
Merge pull request #609 from mate-academy/mate-scripts-update
Vladimir-Beliy Mar 16, 2021
b496116
update @mate-academy/scripts to 0.8.0
Vladimir-Beliy Mar 16, 2021
67a0670
Merge pull request #611 from mate-academy/mate-scripts-update
Vladimir-Beliy Mar 16, 2021
3bddd31
update @mate-academy/bemlint
Vladimir-Beliy Mar 17, 2021
6db41bd
Merge pull request #612 from mate-academy/mate-scripts-update
Vladimir-Beliy Mar 17, 2021
fbbfe2b
Update readme.md
mgrinko Mar 23, 2021
6dd0c26
Update readme.md
aionova Mar 25, 2021
d153344
Update readme.md
mgrinko Mar 25, 2021
1e02718
Update readme.md
mgrinko Mar 25, 2021
c832de7
Update readme.md
mgrinko Mar 25, 2021
448f5a4
added details for onsubmit attribute
VinnieJ-2k20 Mar 29, 2021
e801a3b
fixed linter errors
VinnieJ-2k20 Mar 29, 2021
449a822
Merge pull request #690 from mate-academy/edit-onsubmit-task
mgrinko Mar 29, 2021
58b68a6
update backstop config
YuriiHoliuk May 26, 2021
da6895a
Merge pull request #788 from mate-academy/mate-scripts-update
YuriiHoliuk May 26, 2021
de963e6
update mate-scripts
YuriiHoliuk May 26, 2021
c5688c8
Merge pull request #789 from mate-academy/mate-scripts-update
YuriiHoliuk May 26, 2021
2ecb2e7
update mate-scripts, update layout CI file
YuriiHoliuk Jun 22, 2021
600608a
Merge pull request #818 from mate-academy/mate-scripts-update
YuriiHoliuk Jun 22, 2021
5190a2d
update readme and checklist
VinnieJ-2k20 Sep 13, 2021
b186c73
add checklist link to readme
VinnieJ-2k20 Sep 13, 2021
1d06ada
Merge pull request #1033 from mate-academy/update-checklist
VinnieJ-2k20 Sep 13, 2021
273ec32
improve markup in checklist
VinnieJ-2k20 Sep 14, 2021
9796f02
Merge pull request #1034 from mate-academy/markup-improvement
solaryasha Sep 14, 2021
ea81446
update checklist
VinnieJ-2k20 Oct 26, 2021
b9b2206
Merge pull request #1108 from mate-academy/update-checklist-with-spoi…
VinnieJ-2k20 Oct 26, 2021
edae071
fix screenshot
VinnieJ-2k20 Oct 26, 2021
aaa4659
Merge pull request #1110 from mate-academy/fix-screenshot
VinnieJ-2k20 Oct 26, 2021
694d08b
Update checklist.md
Elena-brv Nov 16, 2021
e614e63
Add jest in package in devDependencies
Nov 19, 2021
f114aa6
Merge pull request #1192 from mate-academy/mate-scripts-update
Ihor-Karpyn Nov 19, 2021
2e3dabe
Add new version of @linthtml/linthtml and @mate-academy/linthtml-conf…
OleksiiBlezniuk Dec 14, 2021
2fd2d3f
Merge pull request #1226 from mate-academy/mate-scripts-update
OleksiiBlezniuk Dec 14, 2021
586abdf
Update .linthtmlrc.json
OleksiiBlezniuk Dec 14, 2021
97eb201
Update readme.md
mgrinko Dec 16, 2021
cc40eb3
Update readme.md
mgrinko Dec 16, 2021
d713474
Update readme.md
mgrinko Dec 16, 2021
f752089
Update readme.md
OleksiiBlezniuk Dec 16, 2021
67cb3bd
Merge pull request #1230 from mate-academy/OleksiiBlezniuk-patch-1
OleksiiBlezniuk Dec 16, 2021
eca5a50
Update readme.md
OleksiiBlezniuk Dec 16, 2021
d3f91f6
Update readme.md
OleksiiBlezniuk Dec 16, 2021
a2f713c
Update readme.md
OleksiiBlezniuk Dec 16, 2021
b18c965
Update readme.md
OleksiiBlezniuk Dec 16, 2021
441087b
Update readme.md
OleksiiBlezniuk Dec 16, 2021
007739d
Update checklist.md
Ihor-Karpyn Dec 20, 2021
c148354
Update readme.md
mgrinko Dec 21, 2021
b83e7c1
Update readme.md
mgrinko Dec 21, 2021
e7399c0
Update checklist.md
solaryasha Jan 17, 2022
e4df06f
Update package.json
Andr1yK Aug 23, 2022
1c21d6e
Merge pull request #2215 from mate-academy/Add-mate-html-linter
Andr1yK Aug 23, 2022
978cd48
Update-package-json
Andr1yK Aug 26, 2022
a1d99c9
Merge pull request #2232 from mate-academy/Update-package-lock-json
Andr1yK Aug 26, 2022
9001b35
Update checklist.md
valerii-derkach Oct 31, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .bemlintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"elementDivider": "__",
"modifierDivider": "--",
"ignore": [
"node_modules",
"dist"
],
"rules": {
"one-block": true,
"one-element": true,
"element-inside-parent-block": true,
"no-double-element": true,
"no-neighbour-parent-block": true,
"modifiable-class": true
}
}
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
end_of_line = lf
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/backstop_data
/src/report
/dist
29 changes: 29 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: backstop_data
12 changes: 10 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# IDE
.idea
.vscode

# Node
node_modules

# MacOS
.DS_Store
yarn.lock

# Generated files
backstop_data
!backstop_data/engine_scripts/
dist
.cache
3 changes: 3 additions & 0 deletions .linthtmlrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "@mate-academy/linthtml-config"
}
2 changes: 1 addition & 1 deletion .stylelintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/backstop_data/
/src/report
/dist
10 changes: 8 additions & 2 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
module.exports = {
extends: "@mate-academy/stylelint-config",
extends: [
"stylelint-config-recommended-scss",
"@mate-academy/stylelint-config"
],
plugins: [
"stylelint-scss"
],
rules: {}
}
};
9 changes: 0 additions & 9 deletions .travis.yml

This file was deleted.

57 changes: 57 additions & 0 deletions backstopConfig.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
'use strict';
// https://github.com/garris/BackstopJS#advanced-scenarios

const backstop = require('@mate-academy/backstop-config');
const { basicScenario } = backstop;

const basic = {
...basicScenario,
label: 'Elementary test',
referenceUrl: basicScenario.referenceUrl + '/html-form/',
};

const config = {
...backstop,
fileNameTemplate: '{scenarioLabel}-{selectorIndex}',
viewports: [
{
name: 'tablet_h',
width: 1024,
height: 768,
},
],
scenarios: [
{
...basic,
label: 'Entire document',
selectors: ['document'],
},
{
...basic,
label: 'Form',
selectors: ['form'],
},
{
...basic,
label: 'Fieldset tag', // all fieldsets are different
selectors: ['fieldset'],
},
{
...basic,
label: 'Submit button',
selectors: ['[type="submit"]'],
},
{
...basic,
label: 'Email with placeholder',
selectors: ['[type="email"][placeholder]'],
},
{
...basic,
label: 'Number with value',
selectors: ['[type="number"][value]'],
},
],
};

module.exports = config;
68 changes: 68 additions & 0 deletions checklist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
1. [CODE STYLE] - Keep your code line length below 80. It’s not only historical
tradition, but also allows your code to fit into one standard screen without
horizontal scroll.
But do not break the line if it cannot be broken (ex., long links).


2. [CODE STYLE] - Remember about correct indentation between parent and child
elements. Each level of nesting, including text, contained inside the element,
requires 2-space offset.
<details>
<summary>BAD examples</summary>
![html-indentations-bad-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-indentations/example-bad-1.png)
</details>
<details>
<summary>GOOD example</summary>
![html-indentations-good-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-indentations/example-good-1.png)
</details>


3. [CODE STYLE] - If the HTML-element has long attribute values or number of
attributes is more than 2 - start each one, including the first, on the new
line with 2-space indentation related to tag. Tag’s closing bracket should be
on the same level as opening one.
<details>
<summary>BAD examples</summary>
![html-attributes-bad-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-attributes/example-bad-1.png)
![html-attributes-bad-example-2](https://mate-academy.github.io/fe-program/css/checklists/html-attributes/example-bad-2.png)
![html-attributes-bad-example-3](https://mate-academy.github.io/fe-program/css/checklists/html-attributes/example-bad-3.png)
![html-attributes-bad-example-4](https://mate-academy.github.io/fe-program/css/checklists/html-attributes/example-bad-4.png)
</details>
<details>
<summary>GOOD example</summary>
![html-attributes-good-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-attributes/example-good-1.png)
</details>


4. [CODE STYLE] - Use camelCase for values of name attribute - they should be
valid as JavaScript object keys. It should not contain spaces, “-” or other
special characters.
<details>
<summary>BAD example</summary>
![html-name-attribute-bad-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-name-attribute/example-bad-1.png)
</details>
<details>
<summary>GOOD example</summary>
![html-name-attribute-good-example-1](https://mate-academy.github.io/fe-program/css/checklists/html-name-attribute/example-good-1.png)
</details>


5. [CODE STYLE] - No need to provide empty value="" attribute for inputs. Add
it only if a certain value is specified from the start, or use placeholders.

6. [CODE STYLE] - Don't style tags, use class selector instead

7. [FUNCTIONAL] - You need to use a label tag for each input, so that every
input could be activated by clicking on the corresponding label.

8. [FUNCTIONAL] - Check the textarea behaviour - when you click on the textarea,
the coursor should appear on the beginning of the input.

9. [TESTS] - Remember, you need to add a certain distance BETWEEN inputs and
BETWEEN blocks with inputs. It means that, for example, the last input in
the group of inputs should not have a set bottom margin.


10. [TESTS] - Remember, any other styles besides margins, should be browser
default.

83 changes: 0 additions & 83 deletions config/backstop/backstopConfig.js

This file was deleted.

9 changes: 0 additions & 9 deletions config/hooks/deploy.sh

This file was deleted.

3 changes: 0 additions & 3 deletions config/hooks/start-server.sh

This file was deleted.

Loading