Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version command for the cli using ldflags #23

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

anveshthakur
Copy link
Contributor

Hi @osteensco,
I've added the -version, -v command to show the version
It takes the release version from Github and then puts it into the program at the time of building the project

This PR is for the issue #15

@osteensco
Copy link
Owner

Thanks for the PR, can you add a couple of things:

  • macOS support
  • fastTravelCLI ASCII logo above the version output
  • at least one unit test
  • ensure your branch is caught up with master as I fixed some broken tests

I was reviewing this on my phone so apologies if your PR already addresses some of these and I just missed it.

@anveshthakur
Copy link
Contributor Author

Hi @osteensco,

I've added all the changes you've listed down.
LMK if there is anything else you want me to change or add.

Thanks!

@osteensco
Copy link
Owner

Fixed a test that wasn't passing, thanks for the PR!

@osteensco osteensco merged commit 0a35b5f into osteensco:master Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants