Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding myself to the staff page #641

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding myself to the staff page #641

wants to merge 2 commits into from

Conversation

Thats-Neat
Copy link

No description provided.

@Thats-Neat Thats-Neat marked this pull request as draft November 13, 2024 23:13
@Thats-Neat Thats-Neat self-assigned this Nov 13, 2024
@Thats-Neat
Copy link
Author

@ramereth tests don't pass but it seemingly looks fine

@Thats-Neat Thats-Neat marked this pull request as ready for review November 13, 2024 23:43
@ramereth
Copy link
Member

@Thats-Neat there are linting issues. See the continuous-integration/jenkins/pr-head jenkins run. You can also check this by doing make lint_changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramereth ramereth Awaiting requested review from ramereth

At least 1 approving review is required to merge this pull request.

Assignees

@Thats-Neat Thats-Neat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thats-Neat @ramereth