Update site content #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaetep
force-pushed
the
antoniagaete/update_site_content
branch
from
f6284dd
to
c208afb
Compare
ramereth
requested changes
Oct 10, 2023
There was a problem hiding this comment.
A few issues
- The /services page isn't showing the landing page I'm expecting
- Not all URLs are the same between the current and new site (i.e.
/peoplevs/about/people). Please make sure every URL is the same as the current site - The contact page isn't displaying the addresses properly. It looks like you need to add two trailing spaces to each line to get Hugo to create a
<br> - There are some white spaces in
data/projects.ymlthat should be removed. You might double check other files for extra white spaces.
I don't see any white spaces, could you point them out to me? |
|
@antoniagaete depending on your editor, you can make it easier to find. But here's one example: Line 1 in 931eb5a |
|
@ramereth I had originally formatted it that way, but fixed it up to look more compact |
ramereth
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.