Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro/no-deprecated-getentrybyslug rule #234

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

morinokami
Copy link
Contributor

In the latest Astro, the function getEntryBySlug has been deprecated. However, I noticed that there wasn't any rule regarding this function, so I added one.

I ran npm run new to add a new rule, followed by npm run update. Apologies if I've misunderstood or misfollowed any procedure!

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2023

🦋 Changeset detected

Latest commit: e6177db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The new rule and it implementation look very good!

@ota-meshi ota-meshi merged commit e13ea7c into ota-meshi:main Jul 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants