Skip to content

Commit

Permalink
chore: use eslint v9 (#333)
Browse files Browse the repository at this point in the history
* chore: use eslint v9

* fix
  • Loading branch information
ota-meshi authored Jun 21, 2024
1 parent 0ccacb1 commit 455c00a
Show file tree
Hide file tree
Showing 21 changed files with 427 additions and 357 deletions.
40 changes: 18 additions & 22 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,31 +1,27 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
"name": "Node.js & TypeScript",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye",
"name": "Node.js & TypeScript",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye",

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},
// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "yarn install",
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "yarn install",

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {},
"extensions": [
"dbaeumer.vscode-eslint"
]
}
}
// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
"extensions": ["dbaeumer.vscode-eslint"]
}
}

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
15 changes: 0 additions & 15 deletions .eslintignore

This file was deleted.

215 changes: 0 additions & 215 deletions .eslintrc.js

This file was deleted.

22 changes: 12 additions & 10 deletions .github/workflows/NodeCI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,12 @@ jobs:
test:
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [18.x, 20.x]
os: [ubuntu-latest]
include:
- node: 18.x
- node: 22.x
os: windows-latest
- node: 18.x
os: macos-latest
- node: 14.x
os: windows-latest
- node: 14.x
- node: 22.x
os: macos-latest
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -43,14 +39,20 @@ jobs:
run: yarn install --ignore-engines
- name: Test
run: yarn test
test-with-eslint9:
test-with-eslint8:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Install Target Packages
run: |+
yarn add -D eslint@^9.0.0-0 --ignore-engines
yarn add -D eslint@8 --ignore-engines
yarn --ignore-engines
- name: Test
run: yarn test
Expand Down
2 changes: 1 addition & 1 deletion .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{}
{}
Loading

0 comments on commit 455c00a

Please sign in to comment.