Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] On-the-fly data loading of global models #1495

Closed
wants to merge 17 commits into from
Closed

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

🔮 Key changes

  • On the fly sampling of the dataloader

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@SimonWittner SimonWittner self-assigned this Dec 15, 2023
@SimonWittner SimonWittner added the status: in development Pull requests which are in development label Dec 15, 2023
Copy link

github-actions bot commented Dec 19, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 31.6338 31.6338 0.0%
AirPassengers RMSE_val 32.6669 32.6669 0.0%
AirPassengers Loss_val 0.01372 0.01372 0.0%
AirPassengers MAE 6.24137 6.24137 0.0%
AirPassengers RMSE 7.82929 7.82929 0.0%
AirPassengers Loss 0.00063 0.00063 0.0%
AirPassengers time 10.2346 11.09 8.36%
YosemiteTemps MAE_val 0.64178 0.64178 0.0%
YosemiteTemps RMSE_val 0.92787 0.92787 0.0%
YosemiteTemps Loss_val 0.0005 0.0005 0.0%
YosemiteTemps MAE 1.092 1.092 0.0%
YosemiteTemps RMSE 1.89124 1.89124 0.0%
YosemiteTemps Loss 0.00155 0.00155 0.0%
YosemiteTemps time 62.2979 58.57 -5.98% 🎉
EnergyPriceDaily MAE_val 5.55889 5.55889 0.0%
EnergyPriceDaily RMSE_val 7.12233 7.12233 0.0%
EnergyPriceDaily Loss_val 0.02829 0.02829 0.0%
EnergyPriceDaily MAE 6.37172 6.37172 0.0%
EnergyPriceDaily RMSE 8.53016 8.53016 0.0%
EnergyPriceDaily Loss 0.02907 0.02907 0.0%
EnergyPriceDaily time 15.2201 15.48 1.71%
PeytonManning MAE_val 0.3466 0.3466 0.0%
PeytonManning RMSE_val 0.49808 0.49808 0.0%
PeytonManning Loss_val 0.01752 0.01752 0.0%
PeytonManning MAE 0.34735 0.34735 0.0%
PeytonManning RMSE 0.48788 0.48788 0.0%
PeytonManning Loss 0.01457 0.01457 0.0%
PeytonManning time 21.7667 20.71 -4.85%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5c45f46) 88.33% compared to head (660934c) 88.26%.
Report is 1 commits behind head on main.

Files Patch % Lines
neuralprophet/time_dataset.py 83.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
- Coverage   88.33%   88.26%   -0.08%     
==========================================
  Files          38       38              
  Lines        5099     5128      +29     
==========================================
+ Hits         4504     4526      +22     
- Misses        595      602       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonWittner
Copy link
Collaborator Author

Changes merged with PR #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in development Pull requests which are in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drastically increased memory load
1 participant