Extended collection of useful transformations #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miha-jenko
approved these changes
Jul 18, 2024
| @@ -12,8 +12,8 @@ class TestCategoricalClassification(unittest.TestCase): | |||
| def setUp(self): | |||
| self.cc_instance = CategoricalClassification() | |||
|
|
|||
| def test_init(self): | |||
| self.assertEqual(self.cc_instance.dataset_info, '') | |||
| # def test_init(self): | |||
| result = self.cc_instance._or(arr) | ||
| expected = np.array([1, 1, 1]) | ||
| self.assertTrue(np.array_equal(result, expected), 'OR operation did not produce expected result') | ||
| # def test_xor_operation(self): |
There was a problem hiding this comment.
Tests were created by @98MM , he'll have to review before we remove. This is to make everything operate fine for now.
There was a problem hiding this comment.
Fixed the tests and an error in logical combination functions, should I make a new PR?
There was a problem hiding this comment.
Also, should I keep
if __name__ == '__main__':
unittest.main()I used for local testing in my tests file? I noticed some of the other test files lack it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.outbrain.com/browse/REF-56123
also fixes tests