REF-1523-Recursive feature ranking/evolution #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxappuser
changed the title
miha-jenko
requested changes
Oct 24, 2024
miha-jenko
requested changes
Oct 24, 2024
miha-jenko
previously approved these changes
Oct 24, 2024
jasnaurbancic
approved these changes
Oct 25, 2024
bmramor
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Nice refactoring and automation of evolution!
Would be nice to note whether the MI evolution works in any way, since this seems a bit experimental.
The projections seems like a good idea, since the old evolution had a relatively large drop for longer feature sets... It might be worth investigating the optimal dimensions, though.
| tmp_feature = input_dataframe[feature].tolist() | ||
| for enx, el in enumerate(tmp_feature): | ||
| combined_feature[enx] = str( | ||
| internal_hash( |
There was a problem hiding this comment.
do we still need internal_hash?
|
|
||
| logger = logging.getLogger('syn-logger') | ||
| logger.setLevel(logging.DEBUG) | ||
|
|
||
| num_folds = 4 | ||
| NUM_FOLDS = 2 | ||
| SVD_DIMS = 2 |
There was a problem hiding this comment.
Just a default for now, was fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refurbished a bit
https://jira.outbrain.com/browse/REF-1523