Skip to content

Commit

Permalink
Not push back a prd_set reference when the push updater stops
Browse files Browse the repository at this point in the history
A push updater does not take any producer set references when it starts.
Putting a producer set reference back when it stops will cause a
use-after-free issue.
  • Loading branch information
nichamon authored and tom95858 committed Jan 18, 2021
1 parent fca7a1d commit 40d3d59
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ldms/src/ldmsd/ldmsd_updtr.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ static int cancel_set_updates(ldmsd_prdcr_set_t prd_set, ldmsd_updtr_t updtr)
}
/* Put the push reference */
prd_set->push_flags &= ~LDMSD_PRDCR_SET_F_PUSH_REG;
ldmsd_prdcr_set_ref_put(prd_set);
return rc;
}

Expand Down

0 comments on commit 40d3d59

Please sign in to comment.