Add test mode support for loglevel command in ldmsd_controller

ovis-hpc · Oct 28, 2024 · bfd5824 · bfd5824
1 parent 290a9aa
commit bfd5824
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/ldms/python/ldmsd/ldmsd_communicator.py b/ldms/python/ldmsd/ldmsd_communicator.py
@@ -76,7 +76,7 @@
                       'udata_regex': {'req_attr': ['instance', 'regex', 'base'],
                                       'opt_attr': ['incr']},
                       'version': {'req_attr': [], 'opt_attr': []},
-                      'loglevel': {'req_attr': ['level'],},
+                      'loglevel': {'req_attr': ['level'], 'opt_attr' : ['test']},
                       'include': {'req_attr': ['path'] },
                       'env': {'req_attr': []},
                       'logrotate': {'req_attr': [], 'opt_attr': []},
@@ -1722,7 +1722,7 @@ def update_time_stats(self, name=None):
             self.close()
             return errno.ENOTCONN, str(e)
 
-    def loglevel(self, level):
+    def loglevel(self, level, is_test = False):
         """
         Change the verbosity level of ldmsd
 
@@ -1733,8 +1733,13 @@ def loglevel(self, level):
         - status is an errno from the errno module
         - data is an error message if status !=0 or None
         """
+        if is_test:
+            __test = "true"
+        else:
+            __test = "false"
         req = LDMSD_Request(command_id=LDMSD_Request.VERBOSITY_CHANGE,
-                            attrs=[LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.LEVEL, value=level)])
+                            attrs=[LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.LEVEL, value=level),
+                                   LDMSD_Req_Attr(attr_id=LDMSD_Req_Attr.TEST, value=__test)])
         try:
             req.send(self)
             resp = req.receive(self)

diff --git a/ldms/python/ldmsd/ldmsd_controller b/ldms/python/ldmsd/ldmsd_controller
@@ -1367,7 +1367,7 @@ class LdmsdCmdParser(cmd.Cmd):
         """
         arg = self.handle_args('loglevel', arg)
         if arg:
-            rc, msg = self.comm.loglevel(arg['level'])
+            rc, msg = self.comm.loglevel(arg['level'], arg['test'])
             if rc:
                 print(f'Error changing log level to arg["level"]: {msg}')