Skip to content

Commit

Permalink
Workaround for GitHub workflow dropping CentOS7 support
Browse files Browse the repository at this point in the history
CentOS7 is old, and GitHub Runner recently uses 'node20' which requires
newer GLIBC that does not exist in CentOS7. As a result, the three
workflows in our repository that use 'ovis-centos-build' image fails to
even checkout the code since `actions/checkout@v3` was implemented in
TypeScript that run using 'node.js'.

According to this:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
CentOS7 is also removed from the supported OS list due to node20 not
supported on CentOS7.

This patch does the following on the CentOS7-based workflows:

- Use `actions/checkout@v1` (instead of v3) because it is implemented as
  a plugin that comes with the GitHub Runner (C++). We do not use any
  advanced features that does not exist in v1.

- Remove the use of `actions/upload-artifact`. v3 is implemented in
  TypeScript, and v1 (C++ Runner Plugin) does not work. The artifact's
  purpose was for debugging.
  • Loading branch information
narategithub authored and tom95858 committed Jul 13, 2024
1 parent dee1416 commit d986eaf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/4.3.3-compat-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
container:
image: ovishpc/ovis-compat-centos7
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v1
- run: sh autogen.sh
- name: build and install
run: |
Expand Down Expand Up @@ -332,7 +332,3 @@ jobs:
for V in 4.3.{3..6}; do
diff -u /test/${V}.enum /test/HEAD-${V}.enum > /test/enum-${V}.diff
done
- uses: actions/upload-artifact@v3
if: ${{ always() }}
with:
path: /test/
2 changes: 1 addition & 1 deletion .github/workflows/build-ddebug-centos7.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
container:
image: ovishpc/ovis-centos-build:latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v1
- run: sh autogen.sh
- run: |
_CFLAGS_=(
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-test-centos7.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
container:
image: ovishpc/ovis-centos-build
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v1
- run: sh autogen.sh
- run: ./configure CFLAGS="-Wall -Werror"
- run: make
Expand All @@ -28,7 +28,7 @@ jobs:
container:
image: ovishpc/ovis-centos-build
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v1
- run: sh autogen.sh
- run: ./configure
- run: make distcheck
Expand All @@ -38,7 +38,7 @@ jobs:
container:
image: ovishpc/ovis-centos-build
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v1
- run: sh autogen.sh
- run: ./configure --enable-rdma CFLAGS="-Wall -Werror"
- run: make

0 comments on commit d986eaf

Please sign in to comment.