Add formatted print attribute to ovis_log()
#1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help compiler warns about print format error.
narategithub
force-pushed
the
ovis-log-printf
branch
from
462bf58
to
a761097
Compare
narategithub
force-pushed
the
ovis-log-printf
branch
from
42b4f76
to
b13407d
Compare
narategithub
force-pushed
the
ovis-log-printf
branch
from
b13407d
to
fdd78ce
Compare
tom95858
reviewed
Jul 26, 2023
There was a problem hiding this comment.
@narategithub this is a great catch. This should be cherry picked into 4.4.1 I think. Some of these errors will cause crashes if the message were ever logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help compiler warns about print format error.