Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable github workflow tests on 'OVIS-4.x.x' #1323

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

narategithub
Copy link
Collaborator

@narategithub narategithub commented Jan 15, 2024

The github workflow tests we have only target pull requests for 'OVIS-4' branch. This patch make them target pull requests for any branch matching 'OVIS-4**' (any branch starting with 'OVIS-4').

@narategithub
Copy link
Collaborator Author

@tom95858 I think we need this to be merged into OVIS-4.4.2 and all pull requests targeting 4.4.2 shall include this so that at least the regular build and compatibility tests in github workflows will run against the PR for 4.4.2.

I'll notify other Pull Requests after this is merged.

@morrone
Copy link
Collaborator

morrone commented Jan 16, 2024

I would suggest instead that we just make a branch called "OVIS-4.4" for all 4.4.X releases, rather than making a new branch for every minor tag. Or maybe better yet, call is "b4.4" to match what I wrote here: https://github.com/ovis-hpc/ovis-wiki/wiki/OVIS-LDMS-Versioning.

Do we plan for the 4.4.X series to have many more releases?

@tom95858
Copy link
Collaborator

@narategithub is this good to go?

@narategithub
Copy link
Collaborator Author

@tom95858 I think it is good to go. Even though we expect this branch to be short-lived, we still at the least want to run the basic github workflow tests on pull requests targeting it.

@tom95858 tom95858 merged commit 0c0a901 into ovis-hpc:OVIS-4.4.2 Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants