Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlink add jobid 4.4.x #1385

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Netlink add jobid 4.4.x #1385

merged 3 commits into from
Apr 18, 2024

Conversation

baallan
Copy link
Collaborator

@baallan baallan commented Apr 4, 2024

This takes care of getting the jobid to the netlink-notifier messages for the many ways in which a process can be created in slurm/lsf without receiving a resource manager environment variable list. The intent is to use the same data source as the job_info/jobid plugins now use.

Processes with uid's below the user range do not get a jobid applied to them.
If enabled, a list of default locations and variable names is checked for a jobid string.
The file location can be overridden. It is reread on inotify events.
This feature is not enabled by default.
The integration test is supplied:ldms-static-test.sh linux_proc_sampler.job.

If enabled, a list of default locations and variable names
is checked. The file location can be overridden.
@baallan baallan requested a review from bschwal April 4, 2024 15:02
@baallan baallan assigned baallan and tom95858 and unassigned baallan Apr 4, 2024
@baallan baallan changed the title Netlink add jobid Netlink add jobid 4.4.x Apr 15, 2024
@bschwal
Copy link
Collaborator

bschwal commented Apr 17, 2024

This change provides a huge improvement in getting job ids for jobs that drop into an environment without slurm environment variables, which is quite often. It will also be a good template for other streams services to get job_id.

@tom95858 tom95858 merged commit 6c87bf5 into ovis-hpc:b4.4 Apr 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants