Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the dependencies in README.md #1387

Closed
wants to merge 1 commit into from
Closed

Clarify the dependencies in README.md #1387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ one the "Code" button. Or use the following command:
* flex
* libreadline
* openssl development library (for OVIS, LDMS Authentication)
* libmunge (for Munge LDMS Authentication plugin)
* Python >= 3.6 and Cython >= 0.25 (for the LDMS Python API and ldmsd_controller)
* libmunge development library (for Munge LDMS Authentication plugin)
* Python >= 3.6 development library and Cython >= 0.25 (for the LDMS Python API and the LDMSD Interface, ldmsd_controller)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we rely on 0.29 for Cython now., but the issue that prompted this was that the user in question didn't read any of this, they just went directly to the Building section which doesn't reference these dependencies. So I think we need a pointer in the "Building" section that refers back to the dependencies section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narategithub could you please collect the versions from the build container that we have? I know it's a pain, but we know that works. Also this readme should refer to that container and how one builds using it.

* doxygen (for the OVIS documentation)

Some LDMS plug-ins have dependencies on additional libraries.
Expand All @@ -98,7 +98,7 @@ One way to obtain those packages is from EPEL (install the epel-release package,
then "yum update"). The packages from EPEL are:

* python3-devel
* python36-Cython
* python3-Cython

## Compling the code

Expand Down
Loading