Correct rails, credits, rx_rate values in advertised producers #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom95858
reviewed
Jul 16, 2024
| @@ -32,7 +32,7 @@ ldmsd_sampler_advertisement - Manual for LDMSD Sampler Advertisement | |||
|
|
|||
| .IP \fBprdcr_listen_add | |||
| .RI "name=" NAME " | |||
| .RI "[disabled_start=" TURE|FALSE "] [regex=" REGEX "] [ip=" CIDR "] [rail=" SIZE "] [credits=" BYTES "] [rx_rate=" RATE_LIMIT "]" | |||
| .RI "[disable_start=" TURE|FALSE "] [regex=" REGEX "] [ip=" CIDR "]" | |||
There was a problem hiding this comment.
TURE --> TRUE
Do we want the spaces around the values? A a user that copied that would get an error; and likely a very confusing one.
tom95858
approved these changes
Jul 16, 2024
|
|
||
| .EX | ||
| .B | ||
| > cat samplerd-1.conf | ||
| .RS 4 | ||
| # Create a listening endpoint | ||
| listen xprt=sock port=411 |
There was a problem hiding this comment.
This isn't strictly needed for the advertiser function, correct? What is the reasoning for including it in the example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.