Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static decomposition #1456

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. Add '[]' record member accessor in static decomposition

    This patch allows static decomposition configuration to easily access
    the record member as follows:
    
    ```
    	...
            { "src":"netdev_list[rx_bytes]" },
    	...
    ```
    narategithub committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d9f86e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c5c447 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54d324c View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fix "fill" detection logic in decomp_static

    If "fill" was correctly specified, `cfg_col->fill` will have a value.
    Otherwise, `cfg-col->fill` will be `NULL`. We should use `cfg_col->fill`
    to determine if "fill" was present.
    Narate Taerat authored and narategithub committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9f95bcd View commit details
    Browse the repository at this point in the history
  2. Fix "fill" string value handling

    The "fill" string value was handled incorrectly. This patch fixes the
    bug.
    Narate Taerat authored and narategithub committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    91318c0 View commit details
    Browse the repository at this point in the history
  3. Fix value increment in test_sampler

    Test sampler access raw metric value with `mval->v_u64` and increment
    that value by 1. This works for integer values. When `mval` contains
    float or double, `mval->v_u64` became big number due to IEEE 754
    binary32 or binary64 format. As such, `test_sampler` should use
    `ldms_mval_as_u64()` to coerce the `mval` to u64 properly.
    Narate Taerat authored and narategithub committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    03383ae View commit details
    Browse the repository at this point in the history