Yaml support #1461
Open
Yaml support #1461
+1,750
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick-enoent could you take a look at these build failures? |
tom95858
reviewed
Oct 9, 2024
ldms/src/ldmsd/ldmsd_config.c
Outdated
| if (lineno) | ||
| strcat(cfg_str, cstr); | ||
| else | ||
| snprintf(cfg_str, sizeof(cstr), cstr); |
There was a problem hiding this comment.
@nick-enoent this sizeof(cstr) is 8, not 256 like you intended. This is what is breaking the build.
There was a problem hiding this comment.
Addressed in the latest commit.
Rename ClusterCtrl to YamlCfg Move YamlCfg to parser_util.py Remove maestro-specific functionailty from YamlCfg
Support for advertisers and producer listeners in YAML configuration file Support for multiple yaml files on configuration line Update error handling in parser_util.c Update error handling in __process_yaml_config_file
nick-enoent
force-pushed
the
yaml_support
branch
from
4dcfd51
to
2b0c658
Compare
Done. |
|
@nick-enoent could you please remove the [wip] from the description and I will accept this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for YAML configuration files for LDMSD.
YAML configuration file allows configuration of an entire cluster in a single YAML file.
Add -y option to LDMSD CLI that loads a YAML configuration file in the same manner as "-c" for LDMS v4 configuration files.
The -y option parses a YAML cluster file and applies relevant configuration to a specific daemon.
New command ldmsd_yaml_parser command that can generate v4 configuration files from a YAML file.