-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b4.4 bug: deprecate -t since it is gone in main, mixes poorly with -l, and exits when there is no preexisting log #1488
base: b4.4
Are you sure you want to change the base?
Conversation
fixes #1443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the change fixes the order dependency of -t
and -l
when they are specified at the command line, -t
won't be supported when it is given in configuration files.
@tom95858 If it is gone from main, I'm fine with making it a no-op+warning in 4.4. Just deleting it could break working scripts. But in theory this should be a community decision? A patch to do that might also add deprecation warnings in 4.4 about all other options that are going away/gone in main. |
@tom95858 revised this pr to deprecate -t. |
@nichamon if we could just check the squash box on the pr, that should take care of it. I don't have any pull/merge controls on the github repo, however. |
This turns -t into a no-op and a warning.
@nichamon found the branch and squashed it. |
truncating the log now works correctly whether the old log exists or not and independent of the ordering of -l and -t commands.