Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracing of origin to output v4 config files #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baallan
Copy link
Collaborator

@baallan baallan commented Nov 8, 2021

also fix minor bugs in store and time handling and formats sampler output for readability so users can tell if they got what they expected for sampler configs.

also fix minor bugs in store and time handling
@baallan
Copy link
Collaborator Author

baallan commented Nov 8, 2021

@nick-enoent please review the changes here and cherry pick lines that still make sense with the refactorings you may have in progress.

Copy link
Contributor

@tom95858 tom95858 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @baallan, thanks for this, can you provide more detail on what "odd things" means in this context?

@baallan
Copy link
Collaborator Author

baallan commented Dec 8, 2021

@tom95858 'odd things' means python/c yaml parser layer behavior equivalent to:

  • explicit quotes are stripped
  • Nu (where N is digits and u is what looks to us like a unit string) is converted to some int according to pyyaml notions of time.
  • the unit multiplier seems like it may only have 1 significant character in some cases
  • where the user may normally expect implicit quoting, it does not occur in favor of time conversion.

My test case demonstrates a few of these that result in int being delivered to our cvt function.
Assuming that we will stay dependent on python builtin yaml parsing, the oddities here are sufficient that I am in favor of dropping support for time units altogether and sticking with the C-defined time parameters we have today.
I have not managed to find documented python libyaml 1.1 unit parsing rules. The time feature is apparently so disgusting in general that the yaml 1.2 specification (Which python doesn't follow) removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants