Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic on json encoding #845

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gfrancqu
Copy link

using json output sometimes trigger a panic, issue seems to happen because a goroutine modify the output object while it is being encoded, adding a mutex solve the issue

using json output sometimes trigger a panic, issue seems to happen because a goroutine modify the output object while it is being encoded, adding a mutex solve the issue
@gfrancqu
Copy link
Author

fix #800

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #845 (543bdde) into develop (5f07a52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #845   +/-   ##
========================================
  Coverage    39.46%   39.46%           
========================================
  Files           42       42           
  Lines         5307     5307           
========================================
  Hits          2094     2094           
  Misses        3115     3115           
  Partials        98       98           
Impacted Files Coverage Δ
github.com/OWASP/Amass/requests/request.go 62.75% <0.00%> (ø)

@caffix
Copy link
Collaborator

caffix commented Jun 27, 2022

The changes have caused the lints/tests to fail and will not be an acceptable solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants