Fix tests for nix 2.17 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also updates nixpkgs to utilize 2.17 for tests
oxalica
requested changes
Jul 28, 2023
There was a problem hiding this comment.
It's a bit concern that some tests are relying on nix's docs which may change over time. But only two are affected. Seems fine to me.
CI should be updated to use devShells.full which includes the locked nixUnstable.
Line 145 in 59bcad0
oxalica
requested changes
Jul 28, 2023
|
Sorry for the late response. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates nixpkgs so nil builds with nix 2.17 and fixes the test expectations.