sidecar: fix comment about fan rotor ordering #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also want to fix |
Aaron-Hartwig
force-pushed
the
sidecar-fan-label-fix
branch
from
34ff243
to
3ddc5db
Compare
Aaron-Hartwig
force-pushed
the
sidecar-fan-label-fix
branch
from
6a76172
to
e7149dd
Compare
|
I think at this point it makes sense to get #1479 merged prior to this and rebase on that since it will remove a bunch of copy paste. |
Aaron-Hartwig
force-pushed
the
sidecar-fan-label-fix
branch
from
4e55c17
to
37e9e85
Compare
mkeeter
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous comment I stated:
This is incorrect, for whatever reason my brain that day was thinking that the inlet fan was more towards the back (aka North) while the outlet fan was towards the front (aka South). This is backwards as we draw air from front to back, not back to front, which means that the inlet fan is actually South while the outlet fan is North. This commit cleans up that error.
There aren't any other system impacts beyond fixing up the comment and fan naming.