Add U.2 error handling #1465
Merged
Add U.2 error handling #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcantrill
approved these changes
Jul 18, 2023
mkeeter
force-pushed
the
u2-error-handling
branch
from
a6c6273
to
e0f29a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, devices in the thermal loop were either removable or not, marked by a boolean flag.
This PR adds a third type of device (
RemovableAndErrorProne) and changes that flag into anenum.The new type of device is applicable to our U.2s: it means that upon any I2C error, we treat the device as safely absent. Previously, only a
NoDeviceerror would treat the device as safely absent; this remains the case for devices markedRemovable.