-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control-plane-agent
and host-sp-comms
to Grapefruit
#1898
Conversation
closes #1793 |
9301406
to
003218c
Compare
lgtm and works on hardware with the uart looped through the FPGA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
control-plane-agent / host-sp-comms changes LGTM!
description: "Cosmo SP5 host cpu", | ||
capabilities: DeviceCapabilities::HAS_SERIAL_CONSOLE, | ||
presence: DevicePresence::Present, // TODO: ok to assume always present? | ||
}, | ||
// If we're building for gimlet, we always claim to have host boot flash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// If we're building for gimlet, we always claim to have host boot flash. | |
// If we're building for a compute sled, we always claim to have host boot flash. |
task/host-sp-comms/src/main.rs
Outdated
@@ -1558,6 +1575,10 @@ cfg_if::cfg_if! { | |||
// gimletlet doesn't have an SP3 to interrupt, but we can wire up an LED | |||
// to one of the exposed E2-E6 pins to see it visually. | |||
const SP_TO_SP3_INT_L: sys_api::PinSet = sys_api::Port::E.pin(2); | |||
} else if #[cfg(target_board = "grapefruit")] { | |||
// we don't have an SP3 interrupt pin, so pick an unconnected GPIO | |||
// TODO this is specific to SP3; but SP5 is coming! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "the name of the constant is wrong" or "we don't yet know which pin will be used for interrupts" or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both! We should probably rename the constant to something like SP_TO_HOST_CPU_INT_L
, but we also don't have any SP5 boards that actually use this pin (since Grapefruit doesn't have it wired up). That will come in a future #[cfg(target_board = "cosmo")]
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second though, I can do the renaming here (552e195)
003218c
to
420caa1
Compare
gimlet_seq
tocpu_seq
in Idol and API crates, and use it for both Gimlet and Grapefruitgrapefruit-seq-server
to do mock power control, likemock-gimlet-seq-server
gimlet
BSP incontrol-plane-agent
tocpu-sled
, and use it for both Gimlet and Cosmousart6
support tohost-sp-comms
, since that's what Grapefruit useshost-sp-comms
,control-plane-agent
, andstm32h7-update-server
tograpefruit/app.toml
control-plane-agent
andhost-sp-comms
Opening as a draft because this depends on oxidecomputer/management-gateway-service#297