Skip to content

sidecar release

Compare
Choose a tag to compare
@github-actions github-actions released this 21 May 13:22
· 115 commits to master since this release
1d3f3d5
transceivers: fix I2C read bug (#1787)

#1768 did not properly account for the FIFO behavior of the FPGA's data
buffers. The "check the status byte" portion of the loop happened
outside the part where we read the buffer, and since the buffer was just
memory-mapped registers it could be repeatedly without consequence.
Since the data was now in a FIFO, I was inadvertently draining the FIFO
before the transaction was done. This PR consolidates the "is I2C done
yet" logic into the `get_i2c_status_and_read_buffer` so calling code can
just deal with the status register and the data buffer.

Fixes #1786